Project files should be saved before search

This is a tough one.

I agree that people will almost always expect to search the current project state - something you get with find-in-project. However, find-in-project doesn't actually save your files to perform its search.

My concern is that folks would be caught off-guard by automatically saving all files. People expect their files to be saved when running a compile or a test-suite but for just searching... not so much.

Also, the 'unsaved work' indicator in the tab-bar is something that I personally rely on (to keep track of where I am) and it would throw me off if that was reset every time I ran ack. I'm probably not the only one to depend on that little dot.

In the end I decided to go for predictability and non-destructiveness by default, figuring that if people disagreed with me they could always just turn on the autosave.